feat: update browserslist and remove overrides workaround #1257
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f606268:
|
Codecov Report
@@ Coverage Diff @@
## alpha #1257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1038 1038
Branches 349 349
=========================================
Hits 1038 1038
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MatanBobi
force-pushed
the
features/update-browserlist
branch
from
e50dd08 to
f606268
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Doing that will require us to use |
|
I don't think we should remove the |
| "browserslist": "4.21.8", | ||
| "caniuse-lite": "1.0.30001502", |
There was a problem hiding this comment.
Can be reverted #1257 (comment)
There was a problem hiding this comment.
This was just a "hack" to make node 14 build pass but it didn't work so I think either way we won't need it.
| "overrides": { | ||
| "browserslist": "4.21.8", | ||
| "caniuse-lite": "1.0.30001502" | ||
| }, |
There was a problem hiding this comment.
Can be reverted #1257 (comment)
|
Can we merge this once we revert the overrides? Since we're already released alphas and this is also targeting the alpha branch, I'd prefer our CI to be passing sooner rather than later. |
There was a problem hiding this comment.
See my initial review (excluding the resolved comment) or @eps1lon's review
|
CI should be green with #1262. We'll continue to need the overrides otherwise we'll encounter this issue again. |
What: Resolves #1242. This updates the
browserslistentry in our package.json.Why: As part of our major version, we're updating the
browserslistsupport.How: Ran
npx browserslist defaultsand updated the browserslist support in our package.json file. I've also removed the temporary workarounds introduced in #1243.Checklist:
docs site