Types for queryByTestId not correct

[ssylvia]

• dom-testing-library version: 3.11.2

Relevant code or config:

What you did:

Used queryByTestId in typescript

What happened:

VSCode gives error that more arguments are expected

Problem description:

Looks like queryByTestId uses the queryByAttribute type: https://github.com/kentcdodds/dom-testing-library/blob/master/typings/queries.d.ts#L52, even thought the attribute argument is automatically bound: https://github.com/kentcdodds/dom-testing-library/blob/master/src/queries.js#L153.

Suggested solution:

Add a new type or pick the keys off the queryByAttribute type.

[ssylvia]

Looks like this might be a regression from 3.11.1 PR #130.

[alexwendte]

I do not understand typescript very well, but it looks like the arguments for the queryBy and getBy functions are being inferred.

https://github.com/kentcdodds/dom-testing-library/blob/f29f551b1d9b031b0d8cf2d2dc436eae229ecc1d/typings/get-queries-for-element.d.ts#L4-L10

The queryByAltText type is broken as well.

[alexwendte]

I can confirm that removing line 8 makes the types work again. I don't know if that is the correct solution though or not.

https://github.com/kentcdodds/dom-testing-library/blob/4b62bf537687e2cb7bf5ce26c56e51a011e51231/typings/query-helpers.d.ts#L7-L12

On a different note, I am curious why the same typing was not applied to the getByAttribute function.

[jgoz]

This is happening because the argument order for attribute and container is wrong on QueryByAttribute. I'll open a PR.

[kentcdodds]

🎉 This issue has been resolved in version 3.12.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀