Bump JSDOM to 21.x #1206
Draft
Bump JSDOM to 21.x #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be5a252:
|
Codecov Report
@@ Coverage Diff @@
## main #1206 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 998 998
Branches 327 327
=========================================
Hits 998 998
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eps1lon
commented
Jan 28, 2023
| "devDependencies": { | ||
| "@testing-library/jest-dom": "^5.11.6", | ||
| "@types/lz-string": "^1.3.34", | ||
| "jest-in-case": "^1.0.2", | ||
| "jest-snapshot-serializer-ansi": "^1.0.0", | ||
| "jest-watch-select-projects": "^2.0.0", | ||
| "jsdom": "^16.4.0", | ||
| "jsdom": "^21.1.0", |
There was a problem hiding this comment.
quite the hefty bump pulling in unrelated breaking changes. Will bump kcd-scripts to jest 29 first, then update kcd-scripts here
BREAKING CHANGE: Minimum supported Node.js version is now 14.x
* Bump kcd-scripts to 9.x * Fix lint issues * fix lint
* Bump kcd-scripts to 13.0.0 * Fix Jest warnings
eps1lon
force-pushed
the
test/jsdom-21
branch
from
e991be4
to
be5a252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing JSDOM 21.x. Only meant as a proof-of-concept for bumping it in
jest-environment-jsdom