fix: safer read of DEBUG_PRINT_LIMIT #1329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
We encountered some issues on our CI. We use Azure DevOps with this image:
using docker/cypress/browsers:node-20.14.0-chrome-126.0.6478.114-1-ff-127.0.1-edge-126.0.2592.61-1
. This was the log produces when a test failed (for a different reason):Apparently process was defined, while process.env was not. I don't see the harm to do this extra check.
Why:
To have proper error logging when a test fails.
How:
I first used patch-package to patch this library on our codebase with the same change. This unblocked our ci and gave us proper logging of this failing test.
I ran the tests after my changes on this repo and no tests were failing.
Checklist:
docs site N/A