-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toHaveClass custom matcher (closes #2) #4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 85 95 +10
Branches 24 26 +2
=====================================
+ Hits 85 95 +10
Continue to review full report at Codecov.
|
@gnapse You are fond of jest custom matchers :) Looks cool though! |
Yeah, I'd like to strike some balance between usefulness and avoiding bloating this lib, so I don't really think I'll propose any new ones for the time being, but these two ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
…ng-library#4) * Add faq entry about dealing with multiple data-testid with the same value * Add contributor * Generalize selector * Update .all-contributorsrc * Update README.md
As discussed in #2 (closes #2)
One thing to note about it: I did this custom matcher so that it can even be used to match more than one class at the same time:
I think this makes it much more useful, and was not difficult to support.