feat: remove mutationobserver shim #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #413 BREAKING CHANGE: MutationObserver is supported by all major browsers and recent versions of JSDOM. If you need, you can create your own shim (using @sheerun/mutationobserver-shim) and attach it to the window.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c96e7f:
|
kentcdodds
changed the title
Codecov Report
@@ Coverage Diff @@
## beta #457 +/- ##
===================================
Coverage 100% 100%
===================================
Files 22 22
Lines 412 412
Branches 99 98 -1
===================================
Hits 412 412
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 7.0.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
kentcdodds
pushed a commit
that referenced
this pull request
Mar 4, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 4, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
kentcdodds
pushed a commit
that referenced
this pull request
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Remove
@sheerun/mutationobserver-shimfrom the projectWhy: MutationObserve is supported by all major platforms we're targeting, and people can still add the shim themselves if they need to.
How: Now, we simply retrieve the
windowfrom the node they give us, and then reference the MutationObserver off of that.Checklist:
docs site N/A
DefinitelyTyped N/A
Closes #413