-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump pretty-format #751
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98513ad:
|
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 657 657
Branches 173 173
=========================================
Hits 657 657 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had to revert the bump the last time due #563. Does pretty format still require a specific node 10 version?
Aha! Jest 26 needs minimum that version due to bugs in the |
@SimenB Sounds great. Once the fix in pretty-format is released we can update the version range here. |
@eps1lon done |
@SimenB Thanks! |
🎉 This PR is included in version 7.22.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Bumping pretty-format to latest major
Why:
Keeping up is always a good thing. And also, v26 supports custom elements (testing-library/react-testing-library#679)
How:
Updated in GH webapp
Checklist:
docs site