Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix missing codecov report in PRs #897

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 19, 2021

What:

Fixes missing codecov reports in PRs

Why:

These are required for PRs to be mergable. Right now only admins can merge.

How:

Set fetch-depth to 0 as suggested

I also changed the action so that it fails CI on failure. Otherwise it's not obvious why the check is missing.

Added flags while we're at it to know where coverage might be missing.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests (once we get the check)
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb6f844:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #897 (eb6f844) into master (47e52d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          941       941           
  Branches       283       283           
=========================================
  Hits           941       941           
Flag Coverage Δ
node-10.14.2 100.00% <ø> (?)
node-12 100.00% <ø> (?)
node-14 100.00% <ø> (?)
node-15 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e52d1...eb6f844. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review February 19, 2021 15:54
@eps1lon eps1lon merged commit a25149d into testing-library:master Feb 19, 2021
@eps1lon eps1lon deleted the core/fix-codecov-pr branch February 19, 2021 15:54
@github-actions
Copy link

🎉 This PR is included in version 7.29.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant