chore(refactor): move queries to TS / prettify some code according ABC #948
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d893896:
|
| ).filter(node => { | ||
| if (node.tagName === 'SELECT') { | ||
| const selectedOptions = Array.from( | ||
| (node as HTMLSelectElement).options, |
There was a problem hiding this comment.
', ' in the end seems redandant
There was a problem hiding this comment.
I think it's their eslint standard because saw it in other places, also it passed my eslint precommit
eps1lon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 953 962 +9
Branches 289 290 +1
=========================================
+ Hits 953 962 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@all-contributors add @simcha90 for code |
|
I've put up a pull request to add @simcha90! 🎉 |
|
🎉 This PR is included in version 7.31.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
#494
Why:
Move to TS
How:
Moved js files to TS files and prettified some code according ABC order
Checklist:
docs site