fix(prefer-to-have-style): do not offer invalid autofix for computed …

…accessors (#306)
testing-library · Jun 4, 2023 · b38b8ea · b38b8ea
1 parent 96c364a
commit b38b8ea
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/__tests__/lib/rules/prefer-to-have-style.js b/src/__tests__/lib/rules/prefer-to-have-style.js
@@ -167,5 +167,15 @@ ruleTester.run("prefer-to-have-style", rule, {
       code: `expect(element.style[0]).toBe(/RegExp/);`,
       errors,
     },
+    {
+      code: `expect(imageElement.style[computed]).toBe(\`inset 0px 0px 0px 400px \${c}\`)`,
+      errors,
+      output: null,
+    },
+    {
+      code: `expect(imageElement.style[computed]).not.toBe(\`inset 0px 0px 0px 400px \${c}\`)`,
+      errors,
+      output: null,
+    },
   ],
 });
diff --git a/src/rules/prefer-to-have-style.js b/src/rules/prefer-to-have-style.js
@@ -169,7 +169,8 @@ export const create = (context) => {
 
       if (
         typeof styleValue.value !== "number" &&
-        !(styleValue.value instanceof RegExp)
+        !(styleValue.value instanceof RegExp) &&
+        styleName.type !== "Identifier"
       ) {
         fix = (fixer) => {
           return [
@@ -208,7 +209,10 @@ export const create = (context) => {
 
       let fix = null;
 
-      if (typeof styleName.value !== "number") {
+      if (
+        typeof styleName.value !== "number" &&
+        styleName.type !== "Identifier"
+      ) {
         fix = (fixer) => {
           return [
             fixer.removeRange([