-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to reflect setup when using the CRA version #242
Comments
Yeah, I have been thinking about it. I even checked other ESLint plugins already included in CRA and they don't mention anything, so not sure what to do. I guess at least we can add a mention within "Installation" to clarify which major version is included in CRA and since when. |
yeah something simple should be enough, we don't have to go that fancy 😄 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think we should add this now since CRA uses v4 and we have released v4. I figured out how to upgrade the plugin to v4 in a CRA project using yarn (with selective dependency resolution), but I don't have any idea how to do this with npm. Additionally, it would be nice to create a PR to upgrade the plugin in CRA. I think @MichaelDeBoey wanted to give it a try. |
Created a PR to add |
Any ideas about how to suggest updating the plugin to v4 in a CRA project using v3 when dependencies are managed with npm? The only thing I can think of is disabling CRA internal ESLint and reinstall ESLint + plugins directly in the project so the user has full control of it, but I would like to avoid this way. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Now that this plugin is part of CRA after this PR facebook/create-react-app#8963 we might want to add a mention to it in the docs. Currently, the docs state how to use this plugin standalone, but probably CRA is far popular to ignore it 😛 . Perhaps we could consider
The text was updated successfully, but these errors were encountered: