Skip to content

Add no-render-in-setup rationale to docs #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theredspoon opened this issue Nov 30, 2022 · 5 comments · Fixed by #697
Closed

Add no-render-in-setup rationale to docs #696

theredspoon opened this issue Nov 30, 2022 · 5 comments · Fixed by #697
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers released on @alpha released

Comments

@theredspoon
Copy link
Contributor

theredspoon commented Nov 30, 2022 •
edited
Loading

Plugin version

5.9.1

What problem do you want to solve?

The rationale for no-render-in-setup is missing from the documentation.

Your take on the correct solution?

Let's add the rationale to the documentation. This rationale was referenced in the feature request conversation here.

The rationale itself is here.

Anything else?

No response

Do you want to submit a pull request to implement this change?

Yes
@theredspoon theredspoon added enhancement New feature or request triage Pending to be triaged by a maintainer labels Nov 30, 2022
@Belco90
Copy link
Member

Belco90 commented Nov 30, 2022

I assume you meant no-render-in-setup?

@theredspoon
Copy link
Contributor Author

Oh gosh, yup. Just saw that mixup.

@theredspoon theredspoon changed the title Add no-node-access rationale to docs Add no-render-in-setup rationale to docs Nov 30, 2022
@theredspoon
Copy link
Contributor Author

Edited the issue and title, thanks for that.

@Belco90 Belco90 added documentation Improvements or additions to documentation good first issue Good for newcomers and removed enhancement New feature or request triage Pending to be triaged by a maintainer labels Nov 30, 2022
@theredspoon theredspoon mentioned this issue Nov 30, 2022
Merged
1 task
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add rationale to no-render-in-setup theredspoon/eslint-plugin-testing-library
2 participants
@Belco90 @theredspoon