Skip to content

chore: migrate dev dependency ESLint to v9 #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

chore: migrate dev dependency ESLint to v9 #1078

wants to merge 11 commits into from
+1,747 −1,176

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Sep 10, 2025 •
edited
Loading

Checks

Changes

  • Upgrade ESLint ecosystem to be compatible with ESLint v9 and flat config
  • Migrate config to flat format
  • Apply other improvements:
    • Enforce consistent type import, so they are separate imports and are in the last position of import groups
    • Remove specific tsconfig for linting, in favor of reusing the base tsconfig to avoid duplication
    • Replace eslint-plugin-import with eslint-plugin-import-x
    • Update lint-staged command

Context

N/A

@Belco90 Belco90 self-assigned this Sep 10, 2025
@Belco90 Belco90 requested a review from a team September 10, 2025 05:46
@Belco90 Belco90 changed the title chore: migrate ESLint to v9 and flat config chore: migrate dev dependency ESLint to v9 Sep 10, 2025
y-hsgw
y-hsgw reviewed Sep 10, 2025
View reviewed changes
package.json
@@ -41,7 +41,7 @@
"generate:rules-doc": "pnpm run build && pnpm run rule-doc-generator",
"format": "pnpm run prettier-base --write",
"format:check": "pnpm run prettier-base --check",
"lint": "eslint . --max-warnings 0 --ext .js,.ts",
"lint": "eslint --max-warnings 0 --report-unused-disable-directives .",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO:
Thanks for adding this report-unused-disable-directives option!🙌
I think it might be better to move it into the config so that it also works in editor integrations (e.g. lint-on-save), not just the CLI. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-hsgw y-hsgw y-hsgw left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Belco90 Belco90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Belco90 @y-hsgw