Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dependencies #530

Merged
merged 1 commit into from
Jan 9, 2022
Merged

fix: update dependencies #530

merged 1 commit into from
Jan 9, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jan 7, 2022 •
edited
Loading

Closes #499

@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Jan 7, 2022
@MichaelDeBoey MichaelDeBoey self-assigned this Jan 7, 2022
@Belco90
Copy link
Member

Belco90 commented Jan 7, 2022

With this PR, #499 isn't necessary anymore, is it?

@MichaelDeBoey
Copy link
Member Author

@Belco90 That's indeed correct 👍

Belco90
Belco90 requested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additional change:

Can you remove the --force flag from the pipeline GitHub action as in the other PR? Thanks

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the update-dependencies branch 2 times, most recently from c063e6d to 048aac0 Compare January 9, 2022 16:18
Belco90
Belco90 requested changes Jan 9, 2022
View reviewed changes
package.json Show resolved Hide resolved
.github/workflows/pipeline.yml Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey changed the title chore: update dependencies fix: update dependencies Jan 9, 2022
@Belco90 Belco90 merged commit 065ffeb into main Jan 9, 2022
@Belco90 Belco90 deleted the update-dependencies branch January 9, 2022 19:13
@github-actions
Copy link

github-actions bot commented Jan 9, 2022

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees

@MichaelDeBoey MichaelDeBoey

Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @Belco90