Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(await-async-util): false positives due to empty strings #733

Conversation

patriscus
Copy link
Contributor

Checks

Changes

  • In detectAsyncUtilWrapper, adapt code to not push empty strings into functionWrapperNames.

Context

Partially fixes #732 : Addresses the first example, but not the latter one.

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for fixing this so quickly 🙏

@Belco90 Belco90 merged commit c2b8515 into testing-library:main Feb 15, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🎉 This PR is included in version 6.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for await-async-utils
2 participants