Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(await-async-query): add auto-fix #917

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

neriyarden
Copy link
Contributor

@neriyarden neriyarden commented Jul 26, 2024

Checks

Changes

  • Add a fixer for the await-async-query rule (add 'await ' before the async queries)
  • Fix some tests names from "An invalid test" to "A valid test" in valid test cases
  • Update tests
  • Update docs

Context

Fixes #914
also some of #202

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (93a6ab9) to head (bfbd457).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   96.23%   96.36%   +0.12%     
==========================================
  Files          44       46       +2     
  Lines        2419     2502      +83     
  Branches     1000     1037      +37     
==========================================
+ Hits         2328     2411      +83     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Belco90 Belco90 self-requested a review August 11, 2024 16:14
MichaelDeBoey
MichaelDeBoey previously approved these changes Oct 17, 2024
lib/rules/await-async-queries.ts Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the feat--add-a-fixer-for-await-async-queries branch from 102c81a to 1facfc3 Compare October 17, 2024 22:08
@MichaelDeBoey MichaelDeBoey force-pushed the feat--add-a-fixer-for-await-async-queries branch from 1facfc3 to a582606 Compare October 19, 2024 01:23
MichaelDeBoey
MichaelDeBoey previously approved these changes Oct 19, 2024
Signed-off-by: Michaël De Boey <info@michaeldeboey.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 'await-async-queries' rule auto-fixable
2 participants