Skip to content

docs: fix example in prefer-screen-queries.md #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

danielrentz
Copy link
Contributor

Checks

Changes

  • Add missing import of "within" in example code of prefer-screen-queries.

Context

Add missing import of "within" in example code.

Signed-off-by: Daniel Rentz <danielrentz@users.noreply.github.com>
@Belco90
Copy link
Member

Belco90 commented Apr 30, 2025

Hi @danielrentz, thanks for your contribution. Can you update your branch with main, please?

@danielrentz
Copy link
Contributor Author

@Belco90 done

@Belco90 Belco90 enabled auto-merge April 30, 2025 07:11
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (26d360e) to head (d2688da).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          46       46           
  Lines        2472     2472           
  Branches     1025     1030    +5     
=======================================
  Hits         2380     2380           
  Misses         92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Belco90 Belco90 added this pull request to the merge queue Apr 30, 2025
Merged via the queue into testing-library:main with commit be6801f Apr 30, 2025
31 checks passed
@Belco90
Copy link
Member

Belco90 commented Apr 30, 2025

@all-contributors please add @danielrentz for docs

Copy link
Contributor

@Belco90

I've put up a pull request to add @danielrentz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants