Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make .toHaveValue() check value of aria-valuenow as a fallback to value #478

Closed
idanen opened this issue Sep 20, 2022 · 1 comment · Fixed by #479
Closed

Make .toHaveValue() check value of aria-valuenow as a fallback to value #478

idanen opened this issue Sep 20, 2022 · 1 comment · Fixed by #479
Labels
released

Comments

@idanen
Copy link
Contributor

idanen commented Sep 20, 2022

Describe the feature you'd like:

Suggesting that .toHaveValue() support elements' aria-valuenow attribute

Suggested implementation:

When element doesn't have the value property, fallback to try and get the aria-valuenow attribute
idanen added a commit to idanen/jest-dom that referenced this issue Sep 20, 2022
@idanen
feat(toHaveValue): Asserting aria-valuenow
21fb204 
Resolves testing-library#478
@idanen idanen mentioned this issue Sep 20, 2022
Merged
4 tasks
@idanen idanen mentioned this issue Oct 2, 2022
Open
idanen added a commit to idanen/jest-dom that referenced this issue Aug 5, 2024
@idanen
feat(toHaveValue): Asserting aria-valuenow
90d8070 
Resolves testing-library#478
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toHaveValue): Asserting aria-valuenow idanen/jest-dom
1 participant
@idanen