Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Testing Library DOM #524

Open
jrolfs opened this issue Sep 22, 2022 · 0 comments
Open

Upgrade Testing Library DOM #524

jrolfs opened this issue Sep 22, 2022 · 0 comments
Assignees
@jrolfs
Labels
5.0 Issues with potential breaking changes to resolve before/in the 5.0 release breaking change This change will require a major version bump

Comments

@jrolfs
Copy link
Member

jrolfs commented Sep 22, 2022

Upgrade Testing Library DOM to the latest major (https://github.com/testing-library/dom-testing-library/releases/tag/v8.0.0).

This will definitely be part of 5.0, but one related breaking change I'm considering is also moving @testing-libarary/dom to peerDependencies since once we drop the legacy ElementHandle implementation, we should no longer no need to bundle the UMD build with Playwright Testing Library.
@jrolfs jrolfs added breaking change This change will require a major version bump 5.0 Issues with potential breaking changes to resolve before/in the 5.0 release labels Sep 22, 2022
@jrolfs jrolfs self-assigned this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrolfs jrolfs

Labels
5.0 Issues with potential breaking changes to resolve before/in the 5.0 release breaking change This change will require a major version bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrolfs