Skip to content

Commit

Permalink
feat: Support stable React 18 release (#1030)
Browse files Browse the repository at this point in the history
  • Loading branch information
eps1lon authored Mar 30, 2022
1 parent ba24a4b commit 01ec707
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ on:
pull_request: {}
jobs:
main:
continue-on-error: ${{ matrix.react != 'current' }}
continue-on-error: ${{ matrix.react != 'latest' }}
# ignore all-contributors PRs
if: ${{ !contains(github.head_ref, 'all-contributors') }}
strategy:
fail-fast: false
matrix:
# TODO: relax `'16.9.1'` to `16` once GitHub has 16.9.1 cached. 16.9.0 is broken due to https://github.com/nodejs/node/issues/40030
node: [12, 14, '16.9.1']
react: [current, next, experimental]
react: [latest, next, experimental]
runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
Expand All @@ -47,7 +47,6 @@ jobs:
# https://reactjs.org/blog/2019/10/22/react-release-channels.html#using-the-next-channel-for-integration-testing
- name: ⚛️ Setup react
run: npm install react@${{ matrix.react }} react-dom@${{ matrix.react }}
if: ${{ matrix.react != 'current' }}

- name: ▶️ Run validate script
run: npm run validate
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@
"dotenv-cli": "^4.0.0",
"kcd-scripts": "^11.1.0",
"npm-run-all": "^4.1.5",
"react": "18.0.0-rc.1",
"react-dom": "18.0.0-rc.1",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"rimraf": "^3.0.2",
"typescript": "^4.1.2"
},
"peerDependencies": {
"react": "18.0.0-rc.1",
"react-dom": "18.0.0-rc.1"
"react": "^18.0.0",
"react-dom": "^18.0.0"
},
"eslintConfig": {
"extends": "./node_modules/kcd-scripts/eslint.js",
Expand Down

0 comments on commit 01ec707

Please sign in to comment.