feat: add reactStrictMode option to enable strict mode render
#1241
+443
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igure` functions from DTL
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99a3602:
|
Codecov Report
@@ Coverage Diff @@
## main #1241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 192 204 +12
Branches 38 42 +4
=========================================
+ Hits 192 204 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eps1lon
approved these changes
Jan 30, 2024
|
Not sure where codecov GH status check is but coverage is at 100%: https://app.codecov.io/github/testing-library/react-testing-library/commit/99a3602cc38c510bcd1546b13056fd70839feee9 |
|
@all-contributors add @yinm for code |
|
I've put up a pull request to add @yinm! 🎉 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add
reactStrictModeoption to enable strict mode renderWhy:
ref: #338
How:
This PR updates
getConfigandconfigurefunctions from DTL for handling RTL options (e.g.reactStrictMode).This PR also wraps UI in
renderfunction withReact.StrictModecomponent whenreactStrictModeis true.By default,
reactStrictModeis false. (according to #338)Checklist:
docs site -> Add
reactStrictModeoption for RTL testing-library-docs#1318