Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump testing packages #5882

Merged

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jan 30, 2024

Bump @testing-library/dom to 9.3.4 and fix failing tests. 9.3.4 is a bug fix for waitFor, but it breaks some of the asynchronous tests in the monorepo. I've tried to make those tests more flexible, by waiting for DOM elements to render before using them.

Bump @testing-library/react to 14.2.1. 14.2 adds a reactStrictMode config option, to test concurrent rendering in React 18.

Bump jsdom to 24.0, which fixes performance problems in v23 at the expense of removing support for :has() (among other things.)

Please request review from @zooniverse/frontend team or an individual member of that team.

Package

  • app-content-pages
  • app-project
  • lib-classifier
  • lib-react-components

How to Review

Run the tests for all the React libraries and apps.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

Maintenance

  • If not from dependabot, the PR creator has described the update (major, minor, or patch version, changelog)

@eatyourgreens
Copy link
Contributor Author

I'm going to mark this as draft until the tests are passing.

@coveralls
Copy link

coveralls commented Jan 30, 2024

Coverage Status

coverage: 81.183% (+0.01%) from 81.173%
when pulling 0697e94 on eatyourgreens:bump-testing-lib-dom
into 0f56899 on zooniverse:master.

@eatyourgreens eatyourgreens marked this pull request as ready for review January 30, 2024 17:27
@eatyourgreens
Copy link
Contributor Author

Forgot to mention that I ran into this while bumping dev dependencies for #5879. @testing-library/dom broke the tests, so seemed worth its own PR.

@eatyourgreens eatyourgreens changed the title Bump @testing-library/dom to 9.3.4 Bump @testing-library packages Jan 31, 2024
@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Jan 31, 2024

@testing-library/react 14.2 just released, with support for React Strict Mode and concurrent rendering, so I've included that here.

@eatyourgreens eatyourgreens changed the title Bump @testing-library packages Bump testing packages Jan 31, 2024
@eatyourgreens eatyourgreens changed the title Bump testing packages chore: bump testing packages Feb 2, 2024
@eatyourgreens eatyourgreens changed the title chore: bump testing packages build(deps-dev): bump testing packages Feb 2, 2024
@eatyourgreens eatyourgreens force-pushed the bump-testing-lib-dom branch 3 times, most recently from 82952a0 to fb5519e Compare February 8, 2024 14:49
Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@goplayoutside3 goplayoutside3 enabled auto-merge (squash) February 8, 2024 19:40
@goplayoutside3 goplayoutside3 merged commit 22bab90 into zooniverse:master Feb 8, 2024
7 checks passed
@eatyourgreens eatyourgreens deleted the bump-testing-lib-dom branch February 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants