-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): bump testing packages #5882
build(deps-dev): bump testing packages #5882
Conversation
I'm going to mark this as draft until the tests are passing. |
.../src/shared/components/CollectionsModal/components/SelectCollection/SelectCollection.spec.js
Outdated
Show resolved
Hide resolved
Forgot to mention that I ran into this while bumping dev dependencies for #5879. |
777c97a
to
bfa91f8
Compare
|
ab2646e
to
9f85925
Compare
82952a0
to
fb5519e
Compare
Bump @testing-library/dom and fix failing tests.
fb5519e
to
828b2ac
Compare
fe303a3
to
60771f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
Bump
@testing-library/dom
to 9.3.4 and fix failing tests. 9.3.4 is a bug fix forwaitFor
, but it breaks some of the asynchronous tests in the monorepo. I've tried to make those tests more flexible, by waiting for DOM elements to render before using them.Bump
@testing-library/react
to 14.2.1. 14.2 adds areactStrictMode
config option, to test concurrent rendering in React 18.Bump
jsdom
to 24.0, which fixes performance problems in v23 at the expense of removing support for:has()
(among other things.)Please request review from
@zooniverse/frontend
team or an individual member of that team.Package
How to Review
Run the tests for all the React libraries and apps.
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedMaintenance