@types/testing-library__react"' has no exported member 'waitFor' #610

denchen · 2020-03-13T01:41:18Z

@testing-library/react version: 10.0.0
react version: 16.13.0
node version: 12.13.0
npm (or yarn) version: 1.21.1

Relevant code or config:

import {  waitFor } from '@testing-library/react';

What happened:

I get a typescript error:

@types/testing-library__react"' has no exported member 'waitFor'.ts(2305)

Reproduction:

I have @testing-library/react@^10.0.0 and @types/testing-library__react@^9.1.3 installed. I believe each is the latest version.

My current workaround is to add // @ts-nocheck to get my test with waitFor() to pass.

The text was updated successfully, but these errors were encountered:

kentcdodds · 2020-03-13T02:11:53Z

This will be fixed as soon as this is merged: DefinitelyTyped/DefinitelyTyped#43102 😁

bbrinx · 2020-03-17T15:35:00Z

@kentcdodds it might be better to close issues once they are actually resolved. Open issues have a better visibility for others encountering the same problem

kentcdodds · 2020-03-17T15:38:59Z

You're not wrong, but I like to only keep issues open for as long as they have action items we can take within the project where they are. It helps keep things organized.

Dobby89 · 2020-03-23T12:59:21Z

I'm still getting this issue using @testing-library/react@10.0.1

tom-sherman · 2020-03-23T15:34:41Z

Me too. @kentcdodds Could you please reopen this issue?

eps1lon · 2020-03-23T15:38:52Z

We have to bump our dependency on @types/testing-library__react once DefinitelyTyped/DefinitelyTyped#43108 is merged. Re-opening since this requires action in this repository.

MattShrider · 2020-04-06T15:17:59Z

@eps1lon Did you mean to re-open this?

--Edit: Nevermind, I needed to restart my typescript server with latest packages.

roychoo · 2020-04-13T11:45:57Z

i still having the same errors

huylocit14054 · 2020-04-15T10:59:39Z

@roychoo, Hi, after I update @types/testing-libary__react to version 10.0.1, I still got the same error. Inside @types/testing-libary__react folder, the package.json file always reference to the @types/testing-libary__dom@* (the newest one). However, as I read my yarn.lock I saw @types/testing-libary__dom@* always point to the older version (6.0.1 for exp). So I think you may have this problem also. I think you need to modify your yarn.lock file.
The solution I used was yarn add @types/testing-library__dom@7.0.1. This somehow fixed my issue.
If not you can remove your node modules and re-install or maybe remove yarn.lock.
Sr for my bad English.

- Issue with missing types: testing-library/react-testing-library#610

tom-sherman · 2020-04-15T11:15:50Z

@huylocit14054 Installing the types yourself is not an ideal solution IMO while @testing-library/dom already includes these as a dependency, there's a potential for them to get out of sync and cause weird errors. This is very much related to #620 and testing-library/dom-testing-library#494

huylocit14054 · 2020-04-15T11:34:04Z

@huylocit14054 Installing the types yourself is not an ideal solution IMO while @testing-library/dom already includes these as a dependency, there's a potential for them to get out of sync and cause weird errors. This is very much related to #620 and testing-library/dom-testing-library#494

@tom-sherman, you are totally correct. So as far as I understand, in my yarn.lock file, the version of @types/testing-library__dom@* is not the newest one as it should be. So I need to do something to update it to the newest version. After fixing my yarn.lock, I can remove @types/testing-library__dom without any problem. Thank you 👍.

nathanbirrell · 2020-04-17T01:21:46Z

Fixed with yarn remove @testing-library/react @testing-library/jest-dom && yarn add @testing-library/react @testing-library/jest-dom

panpan-lin · 2020-04-19T22:24:00Z

Fixed with npm uninstall @testing-library/react @testing-library/jest-dom && npm install --save-dev @testing-library/react @testing-library/jest-dom

matassp · 2020-06-03T06:39:28Z

    "@testing-library/react": "10.0.5",
    "@testing-library/jest-dom": "5.9.0",
    "react": "16.13.1",

I still get the same error. I've tried all solutions mentioned in this issue, and none helps.

samtsai · 2020-06-03T13:52:54Z

@matassp what version of @testing-library/dom is in your yarn.lock or package-lock.json?

gugol2 · 2020-08-23T11:16:58Z

Fixed with yarn remove @testing-library/react @testing-library/jest-dom && yarn add @testing-library/react @testing-library/jest-dom

This fixed my issue with the tests:

...node_modules/@types/testing-library__react"' has no exported member 'screen'

I went from:

"@testing-library/jest-dom": "^4.2.4",
"@testing-library/react": "^9.3.2",

to:

"@testing-library/jest-dom": "^5.11.4",
"@testing-library/react": "^10.4.9",

For the sake of completion I created my app with CRA from npx and I got the following React version:
v16.13.1

Which apparently does not include the proper version of those dependencies to use screen from testing-library/react.

But now I got the following error when running my app:

node_modules/@testing-library/dom/node_modules/pretty-format/build/index.d.ts(7,13):
'=' expected.  TS1005

     5 |  * LICENSE file in the root directory of this source tree.
     6 |  */
  >  7 | import type * as PrettyFormat from './types';
       |             ^
     8 | /**
     9 |  * Returns a presentation string of your `val` object
    10 |  * @param val any potential JavaScript object

So I am rolling back...

nickserv · 2020-08-25T04:56:06Z

Make sure you're using at least TypeScript 3.8, it's required for import type.

gugol2 · 2020-08-25T08:54:58Z

Make sure you're using at least TypeScript 3.8, it's required for import type.

As I said when building my app I run npx CRA with the typescript template flag... (npx should give me the latest stable, right?)

And it landed with a package.json with:

"typescript": "~3.7.2"

I prefer to rollback and not touch too much what CRA gave me, so I am just descructuring the output of render.

nickserv · 2020-08-25T16:22:30Z

What's the exact version of TypeScript you have installed?

gugol2 · 2020-08-25T18:18:57Z

~ means the latest patch, so it would never reach 3.8.x
^ meas latest minor or patch version, so if I had the caret symbol it could potentially install the 3.8.x

Anyway my version is 3.7.5

nickserv · 2020-08-26T14:25:31Z

You'll need something like ^3.7.2 or ~3.8.0. to install at least TypeScript 3.8

gugol2 · 2020-08-26T16:20:56Z

I know... and as I already SAID I used npx CRA with the ts template...

I am not going to upgrade @testing-library/react @testing-library/jest-dom and typescript.

All the dependencies should be fine out of the box.
So I will manage without screen.

Thanks!

fire-cracker · 2020-09-11T06:17:34Z

@gugol2 I have exactly the same issues.

I had some issues with React Testing Library for TS testing-library/react-testing-library#610

gugol2 · 2020-10-03T10:39:17Z

@gugol2 I have exactly the same issues.

Well, I took that approach at that time.
I don't know if running CRA with npx keeps locking the dependencies just the same today, it's been some time...

Sorry I just checked, last release of CRA is 3.4.1 (2020-03-20)
So I guess it must be the same with a fresh project.

I don't find it that painful to just destructure the output of render.

jose920405 · 2020-10-05T03:45:05Z

For new react projects still happening. With last versions of everything.

nickserv · 2020-10-05T07:48:57Z

I believe CRA 4 will fix this

RichMatthews · 2020-10-22T14:52:37Z

still getting this issue

kentcdodds · 2020-10-22T17:19:35Z

CRA 4 hasn't been released yet. Update your version of @testing-library/react

gugol2 · 2020-10-22T22:28:19Z

CRA 4 hasn't been released yet. Update your version of @testing-library/react

@kentcdodds it is not only about RTL, it complains about other dependencies too...

#610 (comment)

I tried but in the end I rolled back, IMHO it is not so much pain to just destructure the output of render.

gugol2 · 2020-10-24T16:05:11Z

Now CRA 4 is here!!!

https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md#400-2020-10-23

"To infinity.... and Beyond"

elioenays · 2021-04-06T17:53:44Z

@roychoo, Hi, after I update @types/testing-libary__react to version 10.0.1, I still got the same error. Inside @types/testing-libary__react folder, the package.json file always reference to the @types/testing-libary__dom@* (the newest one). However, as I read my yarn.lock I saw @types/testing-libary__dom@* always point to the older version (6.0.1 for exp). So I think you may have this problem also. I think you need to modify your yarn.lock file.
The solution I used was yarn add @types/testing-library__dom@7.0.1. This somehow fixed my issue.
If not you can remove your node modules and re-install or maybe remove yarn.lock.
Sr for my bad English.

I solved my problem with that

kentcdodds closed this as completed Mar 13, 2020

eps1lon mentioned this issue Mar 17, 2020

@types/testing-library__react"' has no exported member 'waitFor'. ts(2305) #613

Closed

m7kvqbe1 added a commit to Royal-Navy/design-system that referenced this issue Apr 15, 2020

test(component library): Upgrade from deprecated RTL APIs

d1bbe72

- Issue with missing types: testing-library/react-testing-library#610

m7kvqbe1 added a commit to Royal-Navy/design-system that referenced this issue Apr 15, 2020

test(component library): Upgrade from deprecated RTL APIs

d12bc80

- Issue with missing types: testing-library/react-testing-library#610

matassp mentioned this issue Jun 3, 2020

@types/testing-library__react"' has no exported member 'waitFor' #688

Closed

th3mon added a commit to th3mon/course-price-calculator that referenced this issue Oct 2, 2020

Add test for TragetGroupsStep

830620b

I had some issues with React Testing Library for TS testing-library/react-testing-library#610

sebathomas mentioned this issue Mar 3, 2022

fix(nms): Fix failing test for Policies magma/magma#11921

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@types/testing-library__react"' has no exported member 'waitFor' #610

@types/testing-library__react"' has no exported member 'waitFor' #610

denchen commented Mar 13, 2020

kentcdodds commented Mar 13, 2020

bbrinx commented Mar 17, 2020

kentcdodds commented Mar 17, 2020

Dobby89 commented Mar 23, 2020

tom-sherman commented Mar 23, 2020

eps1lon commented Mar 23, 2020

MattShrider commented Apr 6, 2020 •

edited

Loading

roychoo commented Apr 13, 2020

huylocit14054 commented Apr 15, 2020 •

edited

Loading

tom-sherman commented Apr 15, 2020

huylocit14054 commented Apr 15, 2020

nathanbirrell commented Apr 17, 2020

panpan-lin commented Apr 19, 2020

matassp commented Jun 3, 2020

samtsai commented Jun 3, 2020

gugol2 commented Aug 23, 2020 •

edited

Loading

nickserv commented Aug 25, 2020

gugol2 commented Aug 25, 2020 •

edited

Loading

nickserv commented Aug 25, 2020

gugol2 commented Aug 25, 2020

nickserv commented Aug 26, 2020 •

edited

Loading

gugol2 commented Aug 26, 2020

fire-cracker commented Sep 11, 2020

gugol2 commented Oct 3, 2020 •

edited

Loading

jose920405 commented Oct 5, 2020 •

edited

Loading

nickserv commented Oct 5, 2020

RichMatthews commented Oct 22, 2020

kentcdodds commented Oct 22, 2020

gugol2 commented Oct 22, 2020

gugol2 commented Oct 24, 2020

elioenays commented Apr 6, 2021

@types/testing-library__react"' has no exported member 'waitFor' #610

@types/testing-library__react"' has no exported member 'waitFor' #610

Comments

denchen commented Mar 13, 2020

Relevant code or config:

What happened:

Reproduction:

kentcdodds commented Mar 13, 2020

bbrinx commented Mar 17, 2020

kentcdodds commented Mar 17, 2020

Dobby89 commented Mar 23, 2020

tom-sherman commented Mar 23, 2020

eps1lon commented Mar 23, 2020

MattShrider commented Apr 6, 2020 • edited Loading

roychoo commented Apr 13, 2020

huylocit14054 commented Apr 15, 2020 • edited Loading

tom-sherman commented Apr 15, 2020

huylocit14054 commented Apr 15, 2020

nathanbirrell commented Apr 17, 2020

panpan-lin commented Apr 19, 2020

matassp commented Jun 3, 2020

samtsai commented Jun 3, 2020

gugol2 commented Aug 23, 2020 • edited Loading

This fixed my issue with the tests:

But now I got the following error when running my app:

nickserv commented Aug 25, 2020

gugol2 commented Aug 25, 2020 • edited Loading

nickserv commented Aug 25, 2020

gugol2 commented Aug 25, 2020

nickserv commented Aug 26, 2020 • edited Loading

gugol2 commented Aug 26, 2020

fire-cracker commented Sep 11, 2020

gugol2 commented Oct 3, 2020 • edited Loading

jose920405 commented Oct 5, 2020 • edited Loading

nickserv commented Oct 5, 2020

RichMatthews commented Oct 22, 2020

kentcdodds commented Oct 22, 2020

gugol2 commented Oct 22, 2020

gugol2 commented Oct 24, 2020

elioenays commented Apr 6, 2021

MattShrider commented Apr 6, 2020 •

edited

Loading

huylocit14054 commented Apr 15, 2020 •

edited

Loading

gugol2 commented Aug 23, 2020 •

edited

Loading

gugol2 commented Aug 25, 2020 •

edited

Loading

nickserv commented Aug 26, 2020 •

edited

Loading

gugol2 commented Oct 3, 2020 •

edited

Loading

jose920405 commented Oct 5, 2020 •

edited

Loading