-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't raise TypeScript errors when hydating document
#1304
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c1fdf7:
|
document
document
document
document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to merge this as a fix before merging the peer deps change?
Yeah, I also want to wait a week (or until React 19 alpha comes out) before merging #1305 |
@eps1lon we see type errors since this change:
can be reproduced with:
|
Closes #1250
As a follow-up, we need to make
@types/react-dom
a peer dependency. Sincereact-dom
is a peer, the types also need to be peer. Otherwise you would get the wrong version of@types/react-dom
if you'd install React 19.