-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stop restricting container
option based on hydrate
#1313
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f5f9f9e:
|
0538bff
to
cf10c6b
Compare
cf10c6b
to
f5f9f9e
Compare
@@ -1,4 +1,7 @@ | |||
{ | |||
"extends": "../node_modules/kcd-scripts/shared-tsconfig.json", | |||
"compilerOptions": { | |||
"skipLibCheck": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never actually typechecked the .d.ts
files before.
@@ -179,19 +171,15 @@ export interface RenderHookResult<Result, Props> { | |||
unmount: () => void | |||
} | |||
|
|||
export interface BaseRenderHookOptions< | |||
/** @deprecated */ | |||
export type BaseRenderHookOptions< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just so I'll understand, what's the motivation with changing this one from an interface
to a type
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just an alias for RenderHookOptions
whereas an interface
would create a new type.
container
option based on hydrate
container
option based on hydrate
Closes #1312
Closes #1311
It's really not worth it to have such extensive types just to restrict
container
properly. Especially because it makes composingrender
andrenderHook
so hard. And we do want to encourage wrappingrender
in your tests.