Skip to content

docs: Fixed example code to use "screen" #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2019
Merged

docs: Fixed example code to use "screen" #553

merged 1 commit into from
Dec 17, 2019

Conversation

sakit0
Copy link
Contributor

@sakit0 sakit0 commented Dec 17, 2019

Fixed example code to use screen.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b7c48b:

Sandbox Source
wizardly-grass-c4ipi Configuration
beautiful-http-7fqyz Configuration

@codecov
Copy link

codecov bot commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #553 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #553   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          95     95           
  Branches       15     15           
=====================================
  Hits           95     95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35c213...1b7c48b. Read the comment docs.

@sakit0 sakit0 changed the title docs: Fixed example code docs: Fixed example code to use "screen" Dec 17, 2019
kentcdodds
kentcdodds approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit e6ff3b8 into testing-library:master Dec 17, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @sakito21 for docs

@allcontributors allcontributors bot mentioned this pull request Dec 17, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @sakito21! 🎉

@sakit0 sakit0 deleted the docs-use-screen branch December 17, 2019 22:42
@wooller
Copy link

wooller commented Dec 18, 2019

Why was this added? Im struggling to find reference to screen in react-testing-library outside of this doc change. Typescript also complains that this is not exported :/

@kentcdodds
Copy link
Member

🎉 This PR is included in version 9.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakit0 @kentcdodds @wooller