-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8b106fa:
|
Thanks for this! Could we get some tests please? |
hey @kentcdodds nice to hear from you! added a passing test case |
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 109 117 +8
Branches 16 16
=========================================
+ Hits 109 117 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What do you think @eps1lon?
@all-contributors add @karthick3018 for code |
I've put up a pull request to add @karthick3018! 🎉 |
🎉 This PR is included in version 11.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pointer events added:
Existing code doesn't include pointer events:
Similar to the mouse events:
Checklist:
docs site