Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention to Firefox extension in about.mdx #1100

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Remove mention to Firefox extension in about.mdx #1100

merged 1 commit into from
Aug 8, 2022

Conversation

giovanniPepi
Copy link
Contributor

Linked firefox extension was removed from the store; update the text to remove its mention

Linked firefox extension was removed from the store; update the text to remove its mention
@nickserv
Copy link
Member

Do we know why it was removed? Could we publish it again instead?

@giovanniPepi
Copy link
Contributor Author

It seems that the previous attempts to get the extension on the store running were problematic, and @smeijer is not trying to upload it again so it's in an undefined state currently

testing-library/testing-playground#327

testing-library/testing-playground#344

@smeijer
Copy link
Member

smeijer commented Jun 29, 2022

Copy from the developer hub:

Approved by Add-ons Review Team about a year ago

This version has been screened and approved for the public. Keep in mind that other reviewers may look into this version in the future and determine that it requires changes or should be taken down.

Thank you!

Rejected by Add-ons Review Team 2 months ago

  1. Extensions defining a content security policy that allows eval ('unsafe-eval') are generally not allowed for security and performance reasons. ‘eval’ is only necessary in rare cases.
  • devtools/src/manifest.json line 24

In addition the following is required to complete the review:

  1. Please let us know to what file is '"sha256-6UcmjVDygSSU8p+3s7E7Kz8EG/ARhPADPRUm9P90HLM=" a reference for and how do you obtain it.
  • devtools/src/manifest.json line 24

I'm not sure if @tsuki42 has already attempted to retry, but I'm happy to add others to the Mozilla dev env as well. Just let me know your email address either here, or on twitter dm, and I'll add you.

@tometo-dev
Copy link
Contributor

@smeijer Not yet. Still trying to figure out why they are unhappy about it.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove it until the situation is figured out. It has not been resolved in over a month.

@bmulholland
Copy link

Closes #1134

@MatanBobi MatanBobi merged commit 3c1d8d8 into testing-library:main Aug 8, 2022
@MatanBobi
Copy link
Member

@all-contributors please add @giovanniPepi for docs :)

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @giovanniPepi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants