react: legacyRoot is only supported in React <= 18 #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MatanBobi
reviewed
Apr 8, 2024
| @@ -107,6 +107,8 @@ your components. | |||
|
|
|||
| ### `legacyRoot` | |||
|
|
|||
| **WARNING**: This option is only available when tests run with React 18 and earlier. | |||
There was a problem hiding this comment.
AFAIR and please correct me if I'm wrong, using legacyRoot wasn't available for versions before React 18. Also, I think a note here will be nicer in terms of UX.
Suggested change
| **WARNING**: This option is only available when tests run with React 18 and earlier. | |
| :::note | |
| This option is only available when tests run with React 18. | |
| ::: |
There was a problem hiding this comment.
Legacy root is everything before React 18. We don't officially support React 17 with latest RTL though. But this section is specifically for the React version you have installed not for the RTL version.
There was a problem hiding this comment.
Also: this is not a note but a warning. Feel free to follow-up with an appropriate styling that's specific to our deploy setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for testing-library/react-testing-library#1294
Preview: https://deploy-preview-1380--testing-library.netlify.app/docs/react-testing-library/api#legacyroot