Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed orientation on webmanifest #295

Merged

Conversation

aganglada
Copy link
Collaborator

@aganglada aganglada commented Nov 11, 2020

What:

This PR fixes #224

Why:

We want to support any orientation on PWA

How:

  • Modifiying PWA webmanifest orientation to any

Checklist:

  • Tests N/A
  • Ready to be merged

@smeijer smeijer merged commit b36b4cf into testing-library:develop Nov 14, 2020
@smeijer
Copy link
Member

smeijer commented Nov 14, 2020

Thanks!

@aganglada aganglada deleted the bug/support-all-orientation-pwa branch November 16, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support all orientation PWA
2 participants