fix: close menu popovers when clicking inside preview pane #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR fixes #243
Why:
The way the browser work is how it's behaving, but it's a bit annoying to have popovers hanging around when clicking on the preview. Specially because the end user doesn't know that's an iframe.
How:
Attaching a listener to the
iframe
and propagating amousedown
on the body of the current window.Checklist: