Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make extension build scripts firefox compatible #327

Merged

Conversation

WeslleyNasRocha
Copy link
Contributor

@WeslleyNasRocha WeslleyNasRocha commented Jan 13, 2021

What: Adding support for Firefox extensions

Why: So people who use Firefox can use this extension

How: Adding the web-ext package, we can run and build the extension in firefox

Checklist:

  • Tests
  • Ready to be merged

It is ready to run:

  1. In project root, execute build:devtools:firefox
  2. Then on firefox, go to about:debugging#/runtime/this-firefox
  3. Click on Load temporary add-on
    image
  4. Select the .zip file from <project_root>/dist/ folder and click open
    image
  5. There is 2 warnings about the manifest.json, but testing it out, it works
    image

Peek 13-01-2021 14-53

@zikaari
Copy link

zikaari commented Jan 15, 2021

Are you able to run it in Firefox without having to upgrade to version 3.x.x of crx-bridge?!

@calvellido
Copy link

Tested on Firefox Developer Edition 85.0b9 (64-bit) and working like a charm, thanks!!

@calvellido
Copy link

It's also working in my standard Firefox 84.0.2 (64-bit)

@WeslleyNasRocha
Copy link
Contributor Author

Are you able to run it in Firefox without having to upgrade to version 3.x.x of crx-bridge?!

Yes, my guess is that web-ext is doing some sort of conversion under the hood, cause i didn't even need to change chrome.devtools to browser.devetools

@WeslleyNasRocha
Copy link
Contributor Author

WeslleyNasRocha commented Jan 20, 2021

Can i upload this to firefox store and transfer to you later?

@smeijer
Copy link
Member

smeijer commented Jan 20, 2021

I'll take a look at this tomorrow and come back to you 😊.

Thanks for the work you've done. Much appreciated!

@smeijer smeijer changed the title Firefox extension feat: make extension build scripts firefox compatible Jan 20, 2021
@smeijer smeijer merged commit 4bb74ab into testing-library:develop Jan 20, 2021
@smeijer
Copy link
Member

smeijer commented Jan 20, 2021

Thanks again! The changes are looking good! I'll try get the thing published asap.

@smeijer
Copy link
Member

smeijer commented Jan 20, 2021

Ok. This process was a lot simpler than for the Chrome Store, even tho Mozilla asked to upload the source code, while Google didn't do that.

Anyways, the extension has been submitted, and is "Awaiting Review". 🎉

@WeslleyNasRocha WeslleyNasRocha deleted the feature/firefox-extension branch January 21, 2021 12:12
@smeijer
Copy link
Member

smeijer commented Jan 29, 2021

Still waiting

Screenshot_20210129-213809

@WeslleyNasRocha
Copy link
Contributor Author

Still waiting

Screenshot_20210129-213809

Looks like they are verifying every new extension that come in

@WeslleyNasRocha
Copy link
Contributor Author

@smeijer

Still waiting

Anything yet?

@smeijer
Copy link
Member

smeijer commented Feb 12, 2021

Yeah, bad news. I'm afraid I have to stop trying. I've submitted three versions now.

  • The first time, it was automatically rejected because I missed the question: let me know from which add-on version you've forked this listing. that they asked in the "developer hub".

  • The second time, they couldn't get it running due to some NPM issues

    🚨 Build failed.
    @parcel/transformer-postcss: Could not resolve package "postcss" that satisfies ^8.2.1. Found 7.0.35
    
  • The third time, they mention the resulting code is different from the one in the final xpi.

I don't know what else to do.

@WeslleyNasRocha
Copy link
Contributor Author

I've tried to upload it on zip format and they accepted 😕

I'm gonna add you as a owner too

https://addons.mozilla.org/pt-BR/firefox/addon/testing-playground/

@smeijer
Copy link
Member

smeijer commented Feb 14, 2021

Thanks! You can add ... while I go cry in a corner. Much appreciated! But their review process... Why?

@smeijer
Copy link
Member

smeijer commented Feb 14, 2021

I see that you've added me. Thanks! Also for submitting. I think it depends on the reviewer. You had a different reviewer, whom accepted in 2 days, no questions asked 😅.

Thanks again. Much, much, appreciated.

@WeslleyNasRocha
Copy link
Contributor Author

Hahaha, don't even i know, i just submitted and got accepted right away.

@smeijer
Copy link
Member

smeijer commented Mar 25, 2021

@WeslleyNasRocha , I've published a new version of the Chrome Extension, to fix a bug regarding conflicting query suggestions.

Can you publish a new version for Firefox? I'm a bit hesitant to do it myself 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants