-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make extension build scripts firefox compatible #327
feat: make extension build scripts firefox compatible #327
Conversation
Are you able to run it in Firefox without having to upgrade to version 3.x.x of |
Tested on Firefox Developer Edition 85.0b9 (64-bit) and working like a charm, thanks!! |
It's also working in my standard Firefox 84.0.2 (64-bit) |
Yes, my guess is that |
Can i upload this to firefox store and transfer to you later? |
I'll take a look at this tomorrow and come back to you 😊. Thanks for the work you've done. Much appreciated! |
Thanks again! The changes are looking good! I'll try get the thing published asap. |
Ok. This process was a lot simpler than for the Chrome Store, even tho Mozilla asked to upload the source code, while Google didn't do that. Anyways, the extension has been submitted, and is "Awaiting Review". 🎉 |
Anything yet? |
Yeah, bad news. I'm afraid I have to stop trying. I've submitted three versions now.
I don't know what else to do. |
I've tried to upload it on zip format and they accepted 😕 I'm gonna add you as a owner too https://addons.mozilla.org/pt-BR/firefox/addon/testing-playground/ |
Thanks! You can add |
I see that you've added me. Thanks! Also for submitting. I think it depends on the reviewer. You had a different reviewer, whom accepted in 2 days, no questions asked 😅. Thanks again. Much, much, appreciated. |
Hahaha, don't even i know, i just submitted and got accepted right away. |
@WeslleyNasRocha , I've published a new version of the Chrome Extension, to fix a bug regarding conflicting query suggestions. Can you publish a new version for Firefox? I'm a bit hesitant to do it myself 😅 |
What: Adding support for Firefox extensions
Why: So people who use Firefox can use this extension
How: Adding the web-ext package, we can run and build the extension in firefox
Checklist:
It is ready to run:
build:devtools:firefox
about:debugging#/runtime/this-firefox
.zip
file from<project_root>/dist/
folder and click open