feat: add test setup based on jest and testing-library #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeijer
reviewed
May 23, 2020
|
Thanks. Looking great! One dependency should be moved though. Also what do you think? Should we add one single "app doesn't throw on render" test just to verify that the setup is working? |
|
And last one, do we need to add https://github.com/testing-library/user-event? |
to make App.js work I added a mock for createRange because it caused an exception with CodeMirror. I also add a mock for images
|
I have added the other things that we need. I also create a test, as you suggest, for App.js :) |
smeijer
approved these changes
May 24, 2020
|
Awesome! Thanks. |
smeijer
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that I have added what we need for testing.
In
setupTests.jsI have assigned to window object the export from testing library.