Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reverse order of event log entries #178

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

marcosvega91
Copy link
Member

fix #173
What:

Block the scroll to bottom

Why:

I made this change because is better to read logs from bottom to top

How:

I have added a new component StickyList. This component has three new props than List component.
With these props we can block the scroll to bottom or to top. Eventually we can disable it with follow = false

Checklist:

  • Tests
  • Ready to be merged

@marcosvega91 marcosvega91 self-assigned this Jun 16, 2020
@marcosvega91 marcosvega91 added the feature New feature or request label Jun 16, 2020
Copy link

@sumeeshn sumeeshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used this package at work this morning (via devtools) and found it very useful. Awesome work ppl! I'll try to contribute back when possible.

@smeijer
Copy link
Member

smeijer commented Jun 17, 2020

@sumeesh879, thanks for the review. Much appreciated.

It's also very nice to read that you used it at work 🥰. Can you share that in #64`?

@smeijer smeijer changed the title feat: add sticky scroll feat: reverse order of event log entries Jun 17, 2020
@smeijer smeijer merged commit 7c9f409 into testing-library:develop Jun 17, 2020
@marcosvega91 marcosvega91 deleted the pr/add_sticky_scroll branch June 17, 2020 13:31
@smeijer
Copy link
Member

smeijer commented Jun 17, 2020

@all-contributors please add @sumeesh879 for review

@allcontributors
Copy link
Contributor

@smeijer

I've put up a pull request to add @sumeesh879! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event log should be inversed
3 participants