chore: update lint staged #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
requested changes
May 28, 2020
smeijer
reviewed
May 28, 2020
MichaelDeBoey
approved these changes
May 28, 2020
smeijer
reviewed
May 28, 2020
MichaelDeBoey
requested changes
May 28, 2020
MichaelDeBoey
requested changes
May 29, 2020
| @@ -12,12 +12,13 @@ | |||
| "postbuild:client": "mkdir -p dist/client/public && cp _redirects dist/client/_redirects && cp public/favicon.ico dist/client/favicon.ico && cp public/android-chrome-512x512.png dist/client/public/icon.png && cp -r .well-known dist/client/.well-known", | |||
| "build:server": "cp -r src/lambda/ dist/server", | |||
| "postbuild:server": "mkdir -p dist/server/server && mv dist/client/index.html dist/server/server/", | |||
| "lint": "eslint 'src/**/*.js' --quiet --fix", | |||
| "lint": "eslint . --quiet --fix", | |||
There was a problem hiding this comment.
eslint can only parse .js(x)/.ts(x)-files, right? 🤔
There was a problem hiding this comment.
So we shouldn't run eslint on all files (.) then, right? 🤔
There was a problem hiding this comment.
Now there are only js files. The default extension for eslint is JavaScript file
|
Looking good! Let me know when it's ready to get merged? |
I think that we're ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added to lint-staged all scripts that I think we need.