Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade parcel to v2 (alpha) #96

Merged
merged 1 commit into from
Jun 5, 2020
Merged

chore: upgrade parcel to v2 (alpha) #96

merged 1 commit into from
Jun 5, 2020

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Jun 5, 2020

I've decided to upgrade parcel to the v2 alpha's. We weren't able to include @testing-library/dom in our production bundle, due to an issue with core-js. The issue is caused by the fact that aria-query doesn't include a "modern" bundle, and parcel v1 is handling that in an unexpected way.

Parcel v2 doesn't have this problem. So upgrading parcel will allow us to fix #65.

Some troubles did arise during upgrade, but nothing that couldn't be fixed.

  • I've added a .parcelrc file to the project root, as the postcss transformer wasn't applied out-of-the-box.

  • We now have a proxy "index.css", as parcel no longer changes ".pcss" extensions to ".css". Which is causing troubles in the browser.

  • The purgecss whitelists needed to be expanded, it looks like css files in node_modules are now also purge, while previously they weren't. This might have something to do with the next point.

  • postcss-easy-import has been replaced with postcss-import.

@smeijer smeijer added chore dependencies Pull requests that update a dependency file labels Jun 5, 2020
@smeijer smeijer self-assigned this Jun 5, 2020
@smeijer smeijer force-pushed the feature/parcel-2 branch 2 times, most recently from 97ebbc5 to ad0999c Compare June 5, 2020 12:16
parcel v1 had some trouble with node modules that are importing core-js polyfills.
@smeijer smeijer force-pushed the feature/parcel-2 branch from ad0999c to e47b1aa Compare June 5, 2020 13:53
@smeijer smeijer merged commit 82b694e into develop Jun 5, 2020
@smeijer smeijer deleted the feature/parcel-2 branch June 5, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import testing-library/dom from npm instead of unpkg
1 participant