fix: type when element.maxLength is -1 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 1 1
Lines 160 160
Branches 44 44
=======================================
Hits 158 158
Misses 2 2
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
May 8, 2020
|
@all-contributors please add @pomber for code |
|
I've put up a pull request to add @pomber! 🎉 |
|
🎉 This PR is included in version 10.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using user-event in the browser, not sure if it's officially supported but it mostly works.
There's a problem with
type, it's removing the last char from the text because the browser returns -1 fromelement.maxLength. I changed it to only slice with maxLength when it's a positive number.