ignore maxLength -1 for userEvent.type #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 98.61% 98.65% +0.04%
==========================================
Files 1 1
Lines 144 149 +5
Branches 41 43 +2
==========================================
+ Hits 142 147 +5
Misses 2 2
Continue to review full report at Codecov.
|
apalaniuk
reviewed
Mar 28, 2020
Co-Authored-By: Adam Palaniuk <apalaniuk@users.noreply.github.com>
|
looks like #263 was merged which resolves this. |
|
Sorry I missed this PR! Thanks for the contribution anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem
We use Karma as a test runner and run tests in the browser. When using userEvent.type, the last character of the value is sliced of. The default value for maxLength for inputs in browsers is -1. So this is true in all our tests. So for example
mytestvaluebecomesmytestvalu. A possible fix is ignoring maxLength -1.Wat do you think?