fix(tab): exclude hidden descendants #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden elements should be excluded from tab order. Hidden attribute can be overwritten by stylesheets. There is a bug in jsdom that has to be resolved first. See jsdom/jsdom#3111
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 719 728 +9
Branches 228 232 +4
=========================================
+ Hits 719 728 +9
Continue to review full report at Codecov.
|
|
@all-contributors add @benadamstyles code |
|
@benadamstyles already contributed before to code |
|
🎉 This PR is included in version 12.8.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Mar 9, 2021
Closed
Closed
Merged
This was referenced Oct 11, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Exclude descendants of hidden elements.
Replaces #556
Why:
Browser does not include hidden parts of the DOM tree in tab order.
How:
Run
window.getComputedStyle()for every ancestor element.If one is hidden, exclude the element from tab order.
Checklist: