Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update all deps #513

Merged
merged 4 commits into from
Dec 6, 2020
Merged

chore: update all deps #513

merged 4 commits into from
Dec 6, 2020

Conversation

kentcdodds
Copy link
Member

What: Update all deps

Why: Just to get things up-to-date.

How:

  1. npx ncu --dep prod,dev --upgrade
  2. npm run validate
  3. Fix some linting things
  4. npm run validate

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

Any maintainer is welcome to merge this 👍

@codecov
Copy link

codecov bot commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #513 (9365a88) into master (ecea19c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          674       674           
  Branches       211       211           
=========================================
  Hits           674       674

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecea19c...9365a88. Read the comment docs.

marcosvega91
marcosvega91 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@marcosvega91 marcosvega91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kentcdodds
Copy link
Member Author

Standby... I'm making one more update.

@kentcdodds kentcdodds force-pushed the pr/update-deps branch 2 times, most recently from 51de6cb to e1f6c78 Compare December 2, 2020 23:23
@kentcdodds
Copy link
Member Author

This is ready to go. Anyone can feel free to click the green button if you're happy with the changes :)

@marcosvega91
Copy link
Member

I can’t merge here. I don’t have permission 🤷

@kentcdodds
Copy link
Member Author

Fixed up! Try again.

@marcosvega91 marcosvega91 merged commit 68536fb into master Dec 6, 2020
@marcosvega91 marcosvega91 deleted the pr/update-deps branch December 6, 2020 03:54
@marcosvega91
Copy link
Member

Thank you :) merged 💪

@marcosvega91
Copy link
Member

marcosvega91 commented Dec 6, 2020 •
edited
Loading

It seams that the CI is failing because of this npm/cli#2033.

I think that we need to update the workflow. We can set the env variable ?

The strange thing is that we already run the CI with node 15 on branches and it was not failing 🤔

@kentcdodds
Copy link
Member Author

I think a better solution is to disable husky in CI (HUSKY_SKIP_INSTALL=true) as it doesn't really need to be installed anyway. I just updated my generator: kentcdodds/generator-kcd-oss@d65eb3b (and whoops, it's needed in two places in the validate.yml: kentcdodds/generator-kcd-oss@04b37a6).

@marcosvega91 marcosvega91 mentioned this pull request Dec 6, 2020
Merged
4 tasks
@github-actions
Copy link

🎉 This PR is included in version 12.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosvega91 marcosvega91 marcosvega91 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentcdodds @marcosvega91