-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert exported modules to typescript #599
Conversation
Codecov Report
@@ Coverage Diff @@
## master #599 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 862 871 +9
Branches 327 329 +2
=========================================
+ Hits 862 871 +9
Continue to review full report at Codecov.
|
🎉 This PR is included in version 13.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
text, | ||
init, | ||
{initialSelectionStart, initialSelectionEnd} = {}, | ||
element: HTMLInputElement | HTMLTextAreaElement, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type definition makes it impossible to use elements returned by RTS queries, without type casting.
see: #648
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a PR to fix this: #649
What:
Converted all exported modules to Typescript.
Fixed some bugs / false assumptions along the way.
Added more TODOs to verify previous implementations.
Why:
Closes #598
Closes #594 (hopefully this time for good)
Checklist: