Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): implement iterable on input.files #603

Merged
merged 2 commits into from
Mar 19, 2021
Merged

fix(upload): implement iterable on input.files #603

merged 2 commits into from
Mar 19, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Implement iterable on target.files.

Why:

MDN states that HTMLInputElement.files is a FileList.
The browser also implements the iterable on this object, and some libraries rely on it:
Closes #576

Checklist:

  • N/A Documentation
  • Tests
  • N/A Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #603 (ff22621) into master (4f5b3ec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #603   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          875       879    +4     
  Branches       330       330           
=========================================
+ Hits           875       879    +4     
Impacted Files Coverage Δ
src/upload.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5b3ec...ff22621. Read the comment docs.

@ph-fritsche ph-fritsche changed the title fix(upload): implement iterable in input.files fix(upload): implement iterable on input.files Mar 19, 2021
@ph-fritsche ph-fritsche merged commit 9f6355b into master Mar 19, 2021
@ph-fritsche ph-fritsche deleted the fix-576 branch March 19, 2021 19:15
@github-actions
Copy link

🎉 This PR is included in version 13.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid attempt to spread non-iterable instance. (upload)
1 participant