-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Jest 27 #693
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33aff37:
|
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 934 934
Branches 367 368 +1
=========================================
Hits 934 934 Continue to review full report at Codecov.
|
// eslint-disable-next-line testing-library/no-await-sync-events | ||
await userEvent.type(element, text, {delay}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the plugin not picking up the overload anymore ? 😞
This might be just another reason for us to always return a Promise on userEvent.type
in the next major.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it.
I've opened testing-library/eslint-plugin-testing-library#403 so we can discuss it there. Would you still want to merge this in the meantime or would you rather wait for that to be fixed?
🎉 This PR is included in version 13.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: Upgrade to Jest 27
Why: Ensuring compatibility with breaking changes in Jest 27
How: Upgrading packages
Checklist: