feat: Implement waitFor
#2
Open
+1,011
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jan 14, 2023
eps1lon
changed the title
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
eps1lon
changed the title
waitFor
timdeschryver
approved these changes
Feb 11, 2023
6 tasks
We also test Node.js 14 which doesn't support AbortController
Jest is not suited for this check since has no knowledge about the build matrix. Codecov should check this instead
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 253fe6c:
|
|
@eps1lon Do we still want to move forwards with this effort? |
siriwatknp
reviewed
Jun 4, 2024
|
|
||
| export default function waitFor( | ||
| callback: () => void | Promise<void>, | ||
| options: WaitForOptions, |
There was a problem hiding this comment.
Suggested change
| options: WaitForOptions, | |
| options?: WaitForOptions, |
Should options be optional? Otherwise, I get a TS error if 2nd arg is not provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
API preview
Docs: testing-library/testing-library-docs#1204