fix: switch cleanly between driver types per-file #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we test this when combined with The change itself: LGTM |
Currently if you use `{ driver: 'wd' }` in the beforeHook()
options of one file and `{ driver: 'sync' }` in another, the
`browser` will still point at the previous driver's browser
object - this fixes that.
* wait for promise resolution after createDriver()
* save the browser from the result - the rest is just the same `testium` obj
* when using cached `factory.instance`, reset `testium.browser`
dbushong
force-pushed
the
dpb-safe-driver-switching
branch
from
4bf0c90
to
5087c11
Compare
|
ok, added a test which fails with the old behavior and succeeds with the new, testing successive calls to |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you use
{ driver: 'wd' }in the beforeHook()options of one file and
{ driver: 'sync' }in another, thebrowserwill still point at the previous driver's browserobject - this fixes that.
createDriver()testiumobjfactory.instance, resettestium.browser