feat: add config option to merge chromeOptions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- merge desiredCapabilities.chromeOptions.args by default if specified in config - allow override of desiredCapabilities.chromeOptions.args with merge: false
amkirwan
force-pushed
the
chromeOptions
branch
from
2a7dcb9 to
264b081
Compare
|
Thanks for this feature. A few observations:
|
dbushong
reviewed
Feb 13, 2019
lib/processes.js
Outdated
| args = args.concat(config.get('desiredCapabilities.chromeOptions.args')) | ||
| .filter(function filterIt(opt, idx, arr) { | ||
| return arr.indexOf(opt) === idx; | ||
| }); |
There was a problem hiding this comment.
I think this might need to be a bit more sophisticated for cases like --disk-cache-size=2
There was a problem hiding this comment.
yeah that is a good point I forgot about options like --disk-cache-size=2
dbushong
reviewed
Feb 13, 2019
lib/processes.js
Outdated
|
|
||
| if (config.has('desiredCapabilities.chromeOptions.args')) { | ||
| if (config.has('desiredCapabilities.chromeOptions.mergeArgs') | ||
| && config.get('desiredCapabilities.chromeOptions.mergeArgs') === true) { |
There was a problem hiding this comment.
can probably collapse this to:
if (config.get('desiredCapabilities.chromeOptions.mergeArgs', false) === true) {
dbushong
reviewed
Feb 13, 2019
lib/processes.js
Outdated
| return acc; | ||
| }, {}); | ||
|
|
||
| return Object.entries(objOpts).reduce(function mergeOpts(acc, opt) { |
There was a problem hiding this comment.
Object.entries() requires node 8+; at the moment we want to maintain compatibility with 6+; you can use Object.keys() and a bit more work and maintain compatibility
- use Object.keys for node6 - config.get for 'desiredCapabilities.chromeOptions.mergeArgs' return false by default
|
LGTM; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in config
false