parse package.json "start" env vars correctly #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before: ``` "start": "NODE_OPTIONS=--x npx foo", ``` would break, trying to treat the first part as the command; now it works Ideally we'd just invoke spawn() with command set to the entire command line and pass `shell: true`, but this would result in our pid not being quite right which might cause other problems...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, in
package.json:would break, trying to treat the first part as the command; now it works
Ideally we'd just invoke
spawn()withcommandset to the entire cmdline and pass
shell: true, but this would result in our pid not beingquite right which might cause other problems...
This PR was started by: git wf pr