-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order listeners documentation #74
Conversation
WalkthroughThe change introduces the ability to order listeners in TestNG, allowing control over the sequence of listener execution based on a custom annotation. An implementation of Changes
Related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 4
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/main/asciidoc/docs/testng_listeners.adoc (1 hunks)
Additional comments: 4
src/main/asciidoc/docs/testng_listeners.adoc (4)
- 232-242: The custom annotation
RunOrder
is well-explained and the code snippet is correct. Ensure that the annotation usage is consistent across all examples.- 268-298: The example listeners
MasterOogway
,MasterShifu
, andDragonWarrior
are correctly annotated and demonstrate the feature well. Ensure that the example names and the concept they illustrate are clear to all readers.- 301-312: The code snippet using TestNG APIs to run the test with ordered listeners is correct. Ensure that the method
create
is explained or referenced correctly if it's part of the TestNG API or user-defined.- 357-359: The note and tip at the end provide useful insights into the behavior of the ordered listeners. Ensure that these insights are consistent with TestNG's actual behavior.
e6530c5
to
f723260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature and api looks good. Just go ahead with the implementation.
@juherr - The cooked up poem at the end of the PR review by @coderabbitai is funny 😆 |
@krmahadevan: I'm glad you enjoyed the poem! 😊 Your laughter is music to my ears. If you have any more feedback or need assistance, feel free to let me know.
|
f723260
to
f1ed948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/main/asciidoc/docs/testng_listeners.adoc (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/main/asciidoc/docs/testng_listeners.adoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just merge when it will be available
f1ed948
to
61c886d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/main/asciidoc/docs/testng_listeners.adoc (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/main/asciidoc/docs/testng_listeners.adoc
This PR adds documentation pertaining to how to use the ordering of listeners feature that will be made available in TestNG
7.10.0
Summary by CodeRabbit
org.testng.ListenerComparator
to facilitate listener ordering.