Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should I implement assertEquals(float[], float[]) and assertEquals(double[], double[]) versions with delta? #1803

Closed
danilcha opened this issue May 28, 2018 · 5 comments · Fixed by #1852
Closed

Should I implement assertEquals(float[], float[]) and assertEquals(double[], double[]) versions with delta? #1803

danilcha opened this issue May 28, 2018 · 5 comments · Fixed by #1852
Labels
Feature: assertions

Comments

@danilcha
Copy link

Currently TestNG contains assertEquals(float[], float[]) and assertEquals(double[], double[]) overloads, but no versions with delta parameter. They are rather useless without them. Should I make a pull request?
@juherr
Copy link
Member

juherr commented May 28, 2018

The idea is good, feel free to propose a PR :)

@juherr
Copy link
Member

juherr commented Jun 30, 2018

@atulagrawal Maybe you'd like to fix it? :)

@atulagrawal
Copy link
Contributor

Sure. I will take this up.

atulagrawal added a commit to atulagrawal/testng that referenced this issue Jul 2, 2018
@atulagrawal
Added new method for comparing float and double arrays with delta - F…
9e73eca 
…ixes testng-team#1803
atulagrawal added a commit to atulagrawal/testng that referenced this issue Jul 2, 2018
@atulagrawal
Added new methods for comparing float and double arrays with delta - F…
4748fc8 
…ixes testng-team#1803
@atulagrawal atulagrawal mentioned this issue Jul 2, 2018
Merged
2 tasks
atulagrawal added a commit to atulagrawal/testng that referenced this issue Jul 2, 2018
@atulagrawal
Added new methods for comparing float and double arrays with delta - F…
2a3f4db 
…ixes testng-team#1803
@danilcha
Copy link
Author

Thank you! Could you please also add the assertNotEquals counterparts?

@juherr
Copy link
Member

juherr commented Nov 20, 2018

@danilcha please open a new issue

@danilcha danilcha mentioned this issue Nov 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: assertions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added new methods for comparing float and double arrays with delta - F… atulagrawal/testng
3 participants
@juherr @atulagrawal @danilcha