Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IHookable and IConfigurable callback discrepancy #2704

Closed
krmahadevan opened this issue Jan 4, 2022 · 0 comments · Fixed by #2713
Closed

IHookable and IConfigurable callback discrepancy #2704

krmahadevan opened this issue Jan 4, 2022 · 0 comments · Fixed by #2713
Labels
callback
Milestone
7.6.0

Comments

@krmahadevan
Copy link
Member

Currently TestNG provides the following two ways in which one can intercept test or config executions

  • IHookable
  • IConfigurable

Today TestNG does not distinguish between a successful invocation vs a wilful skip of invoking the callback and so if a user within their run() implementation, decided to never patch through the callback, TestNG would still classify that method as passed.

More details can be found here #2700 (review)

This issue is to track this discrepancy and arrive at a proper solution.
@krmahadevan krmahadevan mentioned this issue Jan 4, 2022
Merged
3 tasks
@krmahadevan krmahadevan added this to the 7.6.0 milestone Jan 7, 2022
krmahadevan added a commit to krmahadevan/testng that referenced this issue Jan 12, 2022
@krmahadevan
IHookable and IConfigurable callback discrepancy
fbb04ef 
Closes testng-team#2704

Ensure that TestNG reports scenarios wherein 
User defines callbacks for configurations/test methods
But fails to invoke those callbacks explicitly 
And also fails in shipping test status to a user
recognized status (PASS|FAILURE|SKIP)
@krmahadevan krmahadevan mentioned this issue Jan 12, 2022
Merged
3 tasks
krmahadevan added a commit to krmahadevan/testng that referenced this issue Jan 15, 2022
@krmahadevan
IHookable and IConfigurable callback discrepancy
b3e2e88 
Closes testng-team#2704

Ensure that TestNG reports scenarios wherein 
User defines callbacks for configurations/test methods
But fails to invoke those callbacks explicitly 
And also fails in shipping test status to a user
recognized status (PASS|FAILURE|SKIP)
krmahadevan added a commit to krmahadevan/testng that referenced this issue Jan 18, 2022
@krmahadevan
IHookable and IConfigurable callback discrepancy
6d20884 
Closes testng-team#2704

Ensure that TestNG reports scenarios wherein 
User defines callbacks for configurations/test methods
But fails to invoke those callbacks explicitly 
And also fails in shipping test status to a user
recognized status (PASS|FAILURE|SKIP)
krmahadevan added a commit to krmahadevan/testng that referenced this issue Jan 18, 2022
@krmahadevan
IHookable and IConfigurable callback discrepancy
5407253 
Closes testng-team#2704

Ensure that TestNG reports scenarios wherein 
User defines callbacks for configurations/test methods
But fails to invoke those callbacks explicitly 
And also fails in shipping test status to a user
recognized status (PASS|FAILURE|SKIP)
krmahadevan added a commit to krmahadevan/testng that referenced this issue Jan 18, 2022
@krmahadevan
IHookable and IConfigurable callback discrepancy
acab947 
Closes testng-team#2704

Ensure that TestNG reports scenarios wherein 
User defines callbacks for configurations/test methods
But fails to invoke those callbacks explicitly 
And also fails in shipping test status to a user
recognized status (PASS|FAILURE|SKIP)
krmahadevan added a commit that referenced this issue Jan 19, 2022
@krmahadevan
IHookable and IConfigurable callback discrepancy
a6f1c79 
Closes #2704

Ensure that TestNG reports scenarios wherein 
User defines callbacks for configurations/test methods
But fails to invoke those callbacks explicitly 
And also fails in shipping test status to a user
recognized status (PASS|FAILURE|SKIP)
@juherr juherr mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
callback
Projects
None yet
Milestone
7.6.0
Development

Successfully merging a pull request may close this issue.

IHookable and IConfigurable callback discrepancy krmahadevan/testng
1 participant
@krmahadevan